-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32] Add API to create user defined size of endpoint array #27341
Merged
mergify
merged 4 commits into
project-chip:master
from
jadhavrohit924:bug-fix/mode_select
Jun 22, 2023
Merged
[ESP32] Add API to create user defined size of endpoint array #27341
mergify
merged 4 commits into
project-chip:master
from
jadhavrohit924:bug-fix/mode_select
Jun 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jadhavrohit924
commented
Jun 20, 2023
•
edited
Loading
edited
- Problem
- Changes
- Testing
PR #27341: Size comparison from 9a5b909 to e244108 Increases (3 builds for psoc6, qpg)
Decreases (6 builds for bl602, cc32xx, psoc6, qpg)
Full report (35 builds for bl602, bl702, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock and
kkasperczyk-no
June 20, 2023 14:10
pullapprove
bot
requested review from
mspang,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
June 20, 2023 14:10
PR #27341: Size comparison from 9a5b909 to 19fefdb Increases (13 builds for bl702, esp32, psoc6, qpg, telink)
Decreases (14 builds for bl602, cc32xx, esp32, psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jadhavrohit924
force-pushed
the
bug-fix/mode_select
branch
from
June 21, 2023 07:32
19fefdb
to
e1b9030
Compare
PR #27341: Size comparison from 534b6d9 to e1b9030 Increases (7 builds for bl702, esp32, nrfconnect, telink)
Decreases (8 builds for bl602, esp32, telink)
Full report (46 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jadhavrohit924
force-pushed
the
bug-fix/mode_select
branch
from
June 21, 2023 09:36
e1b9030
to
b0890f7
Compare
PR #27341: Size comparison from 534b6d9 to b0890f7 Increases (7 builds for bl602, bl702, esp32, nrfconnect, psoc6, telink)
Decreases (14 builds for cc32xx, esp32, psoc6, telink)
Full report (46 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jun 22, 2023
examples/platform/esp32/mode-support/static-supported-modes-manager.h
Outdated
Show resolved
Hide resolved
Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.